Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add realtime priority inheritance mutexes #197

Merged
merged 33 commits into from
Dec 21, 2024
Merged

Add realtime priority inheritance mutexes #197

merged 33 commits into from
Dec 21, 2024

Conversation

saikishor
Copy link
Member

Add realtime priority inheritance mutexes for using within the realtime loops

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.42857% with 30 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (246e57e) to head (8b0bded).

Files with missing lines Patch % Lines
include/realtime_tools/mutex.hpp 46.42% 19 Missing and 11 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   73.16%   70.12%   -3.05%     
==========================================
  Files           7        8       +1     
  Lines         436      492      +56     
  Branches       72       84      +12     
==========================================
+ Hits          319      345      +26     
- Misses         73       92      +19     
- Partials       44       55      +11
Flag Coverage Δ
unittests 70.12% <46.42%> (-3.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/mutex.hpp 46.42% <46.42%> (ø)

Maverobot
Maverobot reviewed Nov 20, 2024
View reviewed changes
test/realtime_mutex_tests.cpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
@saikishor saikishor requested a review from Maverobot November 20, 2024 23:50
atzaros
atzaros suggested changes Nov 21, 2024
View reviewed changes
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
atzaros
atzaros suggested changes Nov 22, 2024
View reviewed changes
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
@saikishor
add first version of the mutex with priority inheritance
c2e1c10
@saikishor
added documentation and remove the copy constructor and assignment op…
05ce6bc 
…erator
@saikishor
change the name of the mutex to priority_inheritance_mutex
1921f21
@saikishor
Remove pthread_mutexattr_setprioceiling as the protocol is set to PTH…
1a18c6e 
…READ_PRIO_INHERIT
@saikishor
templatize the class and create different instance with using
040a904
@saikishor
Add cerr to mention that the owner is died so user is aware of it
742177e
@saikishor
Add tests to the priority inheritance mutex
f392b21
@saikishor
add documentation and more template arguments
bad11ed
@saikishor
Address MR comments
9f33a30
@saikishor
remove the virtual instances from the methods
0a8343f
@saikishor
Change the exceptions to system_error
bb1f880
@saikishor
Change to cerrno
1b371cc
@saikishor
Add noexcept to some methods
1d0f911
@saikishor
use attr_cleanup_t to cleanup properly without any memory_leaks
8ecf332
@saikishor
Remove the protocol and ceiling template arguments
bbfb3ca
@saikishor saikishor force-pushed the add/realtime/mutexes branch from c5250a1 to 91cce17 Compare November 25, 2024 06:09
christophfroehlich
christophfroehlich requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pthread is not available on windows

atzaros
atzaros reviewed Nov 27, 2024
View reviewed changes
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
include/realtime_tools/mutex.hpp Show resolved Hide resolved
include/realtime_tools/mutex.hpp Outdated Show resolved Hide resolved
christophfroehlich
christophfroehlich previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if CI is happy so am I

bmagyar
bmagyar reviewed Dec 3, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@christophfroehlich christophfroehlich merged commit 74d6a83 into ros-controls:master Dec 21, 2024
18 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport humble

@mergify Mergify
Copy link

mergify bot commented Dec 21, 2024 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 21, 2024
@saikishor @mergify
Add realtime priority inheritance mutexes (#197)
b843d42 
---------

Co-authored-by: atzaros <[email protected]>
(cherry picked from commit 74d6a83)
@mergify mergify bot mentioned this pull request Dec 21, 2024
Merged
christophfroehlich pushed a commit that referenced this pull request Dec 21, 2024
@mergify @saikishor
Add realtime priority inheritance mutexes (backport #197) (#246)
7d2ebd3 
Add realtime priority inheritance mutexes (#197)

---------

Co-authored-by: atzaros <[email protected]>
(cherry picked from commit 74d6a83)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atzaros atzaros atzaros approved these changes

@Maverobot Maverobot Maverobot approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@arne48 arne48 Awaiting requested review from arne48

@destogl destogl Awaiting requested review from destogl

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

@VX792 VX792 Awaiting requested review from VX792

@bmagyar bmagyar Awaiting requested review from bmagyar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saikishor @codecov-commenter @christophfroehlich @bmagyar @Maverobot @atzaros