Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Move the header files to .hpp extension (#206) - No deprecation notice #225

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

saikishor
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 87.02703% with 24 lines in your changes missing coverage. Please review.

Project coverage is 77.28%. Comparing base (d3f9eef) to head (ac55a9f).

Files with missing lines Patch % Lines
...ude/realtime_tools/realtime_server_goal_handle.hpp 78.26% 3 Missing and 12 partials ⚠️
include/realtime_tools/realtime_buffer.hpp 86.53% 2 Missing and 5 partials ⚠️
include/realtime_tools/realtime_publisher.hpp 96.36% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble     #225   +/-   ##
=======================================
  Coverage   77.28%   77.28%           
=======================================
  Files           8        8           
  Lines         471      471           
  Branches      179      179           
=======================================
  Hits          364      364           
  Misses         70       70           
  Partials       37       37           
Flag Coverage Δ
unittests 77.28% <87.02%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_box.hpp 100.00% <100.00%> (ø)
src/realtime_clock.cpp 63.82% <ø> (ø)
include/realtime_tools/realtime_publisher.hpp 96.36% <96.36%> (ø)
include/realtime_tools/realtime_buffer.hpp 86.53% <86.53%> (ø)
...ude/realtime_tools/realtime_server_goal_handle.hpp 78.26% <78.26%> (ø)

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we annoy users if we add a message (msvc, gcc but not sure for clang) instead of warnings like we do on newer distros? At least compilation would not break with -Werr then.

@saikishor
Copy link
Member Author

Do we annoy users if we add a message (msvc, gcc but not sure for clang) instead of warnings like we do on newer distros? At least compilation would not break with -Werr then.

Sure! I can add a message instead of a warning

@saikishor
Copy link
Member Author

Do we annoy users if we add a message (msvc, gcc but not sure for clang) instead of warnings like we do on newer distros? At least compilation would not break with -Werr then.

In file included from /home/user/rolling_worspace/ros2_control_ws/src/ros2_control/controller_manager/test/test_chainable_controller/test_chainable_controller.hpp:25,
                 from /home/user/rolling_worspace/ros2_control_ws/src/ros2_control/controller_manager/test/test_controller_manager_srvs.cpp:30:
/home/user/rolling_worspace/ros2_control_ws/src/realtime_tools/include/realtime_tools/realtime_buffer.h:22:100: note: ‘#pragma message: This header include is deprecated. Please update your code to use 'realtime_buffer.hpp' header.’
   22 |   "This header include is deprecated. Please update your code to use 'realtime_buffer.hpp' header.")  //NOLINT

@christophfroehlich christophfroehlich merged commit 397209c into humble Dec 8, 2024
10 checks passed
@christophfroehlich christophfroehlich deleted the move/headers/humble branch December 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants