Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First step towards modernizing the rt publisher (backport #210) #233

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 13, 2024

I think the rt publisher is one of the most commonly used tools in this package.
When ever I was using it I stumbled upon its "weird" API.

This PR is a first step towards modernizing the RealtimePublisher class, providing a tiny bit of comfort by adding a tryPublish method and providing some typedefs similar to the rclcpp::Publisher.

I plan to add a follow up PR where I refactor the NON_POLLING define into a template parameter.


This is an automatic backport of pull request #210 done by Mergify.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.54%. Comparing base (c4407c8) to head (d480b1e).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble     #233      +/-   ##
==========================================
+ Coverage   76.15%   76.54%   +0.39%     
==========================================
  Files           8        8              
  Lines         478      486       +8     
  Branches      183      184       +1     
==========================================
+ Hits          364      372       +8     
  Misses         77       77              
  Partials       37       37              
Flag Coverage Δ
unittests 76.54% <100.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_publisher.hpp 96.82% <100.00%> (+0.46%) ⬆️

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 48e9d15 into humble Dec 19, 2024
10 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-210 branch December 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants