Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #262

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Remove deprecated code #262

merged 5 commits into from
Jan 30, 2025

Conversation

christophfroehlich
Copy link
Contributor

Deprecations are released on Jazzy and Rolling with their sync within the last days.

Fixes #203

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.26%. Comparing base (2fbe2ea) to head (ae6f46f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   70.72%   71.26%   +0.54%     
==========================================
  Files           9        9              
  Lines         526      522       -4     
  Branches       87       87              
==========================================
  Hits          372      372              
+ Misses         99       95       -4     
  Partials       55       55              
Flag Coverage Δ
unittests 71.26% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_box.hpp 85.24% <ø> (ø)
src/realtime_helpers.cpp 38.61% <ø> (+1.47%) ⬆️

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should do this for Jazzy. This might break users code

@christophfroehlich
Copy link
Contributor Author

In principle, I agree :D let @bmagyar decide; I could handle the branching for jazzy.

@christophfroehlich christophfroehlich merged commit 97466b6 into master Jan 30, 2025
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the rm/deprecated_code branch January 30, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated code
3 participants