Skip to content

Commit

Permalink
Apply suggestions from Bence's code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bence Magyar <[email protected]>
  • Loading branch information
saikishor and bmagyar authored May 21, 2024
1 parent a0a40b3 commit 63e4062
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Hardware Groups
*****************************
Hardware Component Groups serve as a critical organizational mechanism within complex systems, facilitating error handling and fault tolerance. By grouping related hardware components together, such as actuators within a manipulator, users can establish a unified framework for error detection and response.

Hardware Component Groups play a vital role in propagating errors across interconnected hardware components. For instance, in a manipulator system, grouping actuators together allows for error propagation. If one actuator fails within the group, the error can propagate to the other actuators, signaling a potential issue across the system. By default, the actuator errors are isolated to their own hardware component, allowing the rest to continue operation unaffected. In the provided ROS2 control configuration, the ``<group>`` tag within each ``<ros2_control>`` block signifies the grouping of hardware components, enabling error propagation mechanisms within the system.
Hardware Component Groups play a vital role in propagating errors across interconnected hardware components. For instance, in a manipulator system, grouping actuators together allows for error propagation. If one actuator fails within the group, the error can propagate to the other actuators, signaling a potential issue across the system. By default, the actuator errors are isolated to their own hardware component, allowing the rest to continue operation unaffected. In the provided ros2_control configuration, the ``<group>`` tag within each ``<ros2_control>`` block signifies the grouping of hardware components, enabling error propagation mechanisms within the system.

Examples
*****************************
Expand Down
2 changes: 1 addition & 1 deletion hardware_interface/src/resource_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ class ResourceStorage
}
// If it is anything other than OK, change the return type of the hardware group state
// to the respective return type
if (value > hw_group_state_.at(group_name))
if (value != return_type::OK)
{
hw_group_state_.at(group_name) = value;
}
Expand Down

0 comments on commit 63e4062

Please sign in to comment.