Apply suggestions from code review

Co-authored-by: Dr. Denis <[email protected]>
ros-controls · Aug 15, 2024 · 6d627b5 · 6d627b5
1 parent 49137f2
commit 6d627b5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/controller_manager/controller_manager/controller_manager_services.py b/controller_manager/controller_manager/controller_manager_services.py
@@ -44,8 +44,8 @@ def service_caller(
     """
     Abstraction of a service call.
 
-    Has an optional timeout to find the service and a mechanism
-    to retry a call of no response is received.
+    Has an optional timeout to find the service, receive the answer to a call
+    and a mechanism to retry a call of no response is received.
 
     @param node Node object to be associated with
     @type rclpy.node.Node
@@ -88,7 +88,7 @@ def service_caller(
         else:
             return future.result()
     raise RuntimeError(
-        f"Could not successfully call service {service_name} in {max_attempts} attempts."
+        f"Could not successfully call service {service_name} after {max_attempts} attempts."
     )
 
 

diff --git a/controller_manager/test/test_spawner_unspawner.cpp b/controller_manager/test/test_spawner_unspawner.cpp
@@ -381,7 +381,7 @@ TEST_F(TestLoadController, spawner_with_many_controllers)
   const std::string controller_base_name = "ctrl_";
   for (size_t i = 0; i < num_controllers; i++)
   {
-    std::string controller_name = controller_base_name + std::to_string(static_cast<int>(i));
+    const std::string controller_name = controller_base_name + std::to_string(static_cast<int>(i));
     cm_->set_parameter(
       rclcpp::Parameter(controller_name + ".type", test_controller::TEST_CONTROLLER_CLASS_NAME));
     ss << controller_name << " ";