Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
destogl authored Sep 4, 2023
1 parent 345370a commit c99eb86
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions joint_limits/include/joint_limits/joint_limiter_interface.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ class JointLimiterInterface
// Initialize and get joint limits from parameter server
for (size_t i = 0; i < number_of_joints_; ++i)
{
// FIXME?(destogl): this seems to be a bit unclear because we use the same namespace for
// limiters interface and rosparam helper functions - should we use here another namespace?
if (!declare_parameters(joint_names[i], node_param_itf_, node_logging_itf_))
{
RCLCPP_ERROR(
Expand Down Expand Up @@ -146,7 +144,6 @@ class JointLimiterInterface
}

protected:
// Methods that each limiter implementation has to implement
JOINT_LIMITS_PUBLIC virtual bool on_init() { return true; }

JOINT_LIMITS_PUBLIC virtual bool on_configure(
Expand Down

0 comments on commit c99eb86

Please sign in to comment.