Apply suggestions from code review

ros-controls · Apr 13, 2023 · f939193 · f939193
1 parent ceb3beb
commit f939193
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 4 deletions.
diff --git a/controller_interface/CMakeLists.txt b/controller_interface/CMakeLists.txt
@@ -11,7 +11,6 @@ set(THIS_PACKAGE_INCLUDE_DEPENDS
 )
 
 find_package(ament_cmake REQUIRED)
-find_package(backward_ros REQUIRED)
 foreach(Dependency IN ITEMS ${THIS_PACKAGE_INCLUDE_DEPENDS})
   find_package(${Dependency} REQUIRED)
 endforeach()

diff --git a/controller_interface/package.xml b/controller_interface/package.xml
@@ -10,7 +10,6 @@
 
   <buildtool_depend>ament_cmake</buildtool_depend>
 
-  <build_depend>backward_ros</build_depend>
   <build_depend>hardware_interface</build_depend>
   <build_depend>rclcpp_lifecycle</build_depend>
   <build_depend>sensor_msgs</build_depend>

diff --git a/hardware_interface/CMakeLists.txt b/hardware_interface/CMakeLists.txt
@@ -17,7 +17,6 @@ set(THIS_PACKAGE_INCLUDE_DEPENDS
 )
 
 find_package(ament_cmake REQUIRED)
-find_package(backward_ros REQUIRED)
 foreach(Dependency IN ITEMS ${THIS_PACKAGE_INCLUDE_DEPENDS})
   find_package(${Dependency} REQUIRED)
 endforeach()

diff --git a/hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp b/hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
@@ -19,7 +19,7 @@
 
 namespace hardware_interface
 {
-/// Constant defining position interface
+/// Constant defining position interface name
 constexpr char HW_IF_POSITION[] = "position";
 /// Constant defining velocity interface
 constexpr char HW_IF_VELOCITY[] = "velocity";