Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MockHardware] Added dynamic simulation functionality. #1028

Merged
merged 14 commits into from
Oct 3, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented May 17, 2023

@fmauch please check :)

  1. part of port from [GenericSystem] Add velocity-only mode in fake_components  #540

@livanov93 I didn't do parallel use of position and velocity interfaces. I wasn't sure how this should be done. Feel free to extend as needed!

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #1028 (16d971b) into master (925f5f3) will decrease coverage by 2.44%.
Report is 524 commits behind head on master.
The diff coverage is 35.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
- Coverage   34.61%   32.18%   -2.44%     
==========================================
  Files          52       94      +42     
  Lines        2981    10175    +7194     
  Branches     1855     6882    +5027     
==========================================
+ Hits         1032     3275    +2243     
- Misses        310      785     +475     
- Partials     1639     6115    +4476     
Flag Coverage Δ
unittests 32.18% <35.38%> (-2.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...oller_interface/chainable_controller_interface.hpp 100.00% <100.00%> (ø)
...lude/controller_interface/controller_interface.hpp 100.00% <100.00%> (ø)
controller_interface/src/controller_interface.cpp 100.00% <100.00%> (+66.66%) ⬆️
controller_manager/src/controller_manager.cpp 37.94% <ø> (-1.77%) ⬇️
...chainable_controller/test_chainable_controller.hpp 100.00% <100.00%> (ø)
...r_manager/test/test_controller/test_controller.hpp 100.00% <100.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...de/hardware_interface/loaned_command_interface.hpp 100.00% <100.00%> (+14.28%) ⬆️
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
... and 70 more

... and 20 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2023

This pull request is in conflict. Could you fix it @destogl?

@destogl destogl added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jun 5, 2023
@destogl destogl force-pushed the add-simple-dynamic-into-mock-hw branch 2 times, most recently from 83fb83d to 3fa2570 Compare June 15, 2023 07:48
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to it (and to a new demo example besides ros-controls/ros2_control_demos#254 with velocity interface ;) )

@destogl destogl force-pushed the add-simple-dynamic-into-mock-hw branch from d0ecea7 to b1c8950 Compare June 26, 2023 20:24
@destogl destogl force-pushed the add-simple-dynamic-into-mock-hw branch from b1c8950 to ea054bc Compare July 12, 2023 17:43
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment about user feedback this looks good an I tested it with a mocked UR5.

@christophfroehlich
Copy link
Contributor

I tested this one successfully with the diffbot from the demos: ros-controls/ros2_control_demos#357

@destogl destogl force-pushed the add-simple-dynamic-into-mock-hw branch from c23d717 to 16d971b Compare October 3, 2023 16:41
@bmagyar bmagyar merged commit f949949 into master Oct 3, 2023
17 of 18 checks passed
mergify bot pushed a commit that referenced this pull request Oct 3, 2023
@destogl destogl deleted the add-simple-dynamic-into-mock-hw branch October 26, 2023 15:33
christophfroehlich added a commit to christophfroehlich/ros2_control that referenced this pull request Nov 16, 2023
christophfroehlich added a commit to christophfroehlich/ros2_control that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants