-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MockHardware] Added dynamic simulation functionality. #1028
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
- Coverage 34.61% 32.18% -2.44%
==========================================
Files 52 94 +42
Lines 2981 10175 +7194
Branches 1855 6882 +5027
==========================================
+ Hits 1032 3275 +2243
- Misses 310 785 +475
- Partials 1639 6115 +4476
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request is in conflict. Could you fix it @destogl? |
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
83fb83d
to
3fa2570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking forward to it (and to a new demo example besides ros-controls/ros2_control_demos#254 with velocity interface ;) )
d0ecea7
to
b1c8950
Compare
b1c8950
to
ea054bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comment about user feedback this looks good an I tested it with a mocked UR5.
I tested this one successfully with the diffbot from the demos: ros-controls/ros2_control_demos#357 |
…without dynamic-mode ON.
c23d717
to
16d971b
Compare
(cherry picked from commit f949949)
…ontrols#1028)" This reverts commit f949949.
…ontrols#1028)" This reverts commit f949949.
@fmauch please check :)
@livanov93 I didn't do parallel use of position and velocity interfaces. I wasn't sure how this should be done. Feel free to extend as needed!