Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build badge branch for rolling to master #1035

Merged
merged 2 commits into from
May 26, 2023

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented May 26, 2023

THe README was stating that for rolling the rolling branch should be used. However, this does not exist and instead the master branch should be used.

While writing #1034 I realized that the README was stating that Rolling is built from the roling branch. Also, the documentation links were pointing to master for the humble build.

fmauch added 2 commits May 26, 2023 17:37
THe README was stating that for rolling the `rolling` branch should be used.
However, this does not exist and instead the `master` branch should be used.
@fmauch fmauch force-pushed the fix_readme_branches branch from 54b3dde to 27020b2 Compare May 26, 2023 17:38
@fmauch
Copy link
Contributor Author

fmauch commented May 26, 2023

Updated author information, as I had setup my container wrong.

@codecov-commenter
Copy link

Codecov Report

Merging #1035 (54b3dde) into master (925f5f3) will decrease coverage by 2.17%.
The diff coverage is 35.16%.

❗ Current head 54b3dde differs from pull request most recent head 27020b2. Consider uploading reports for the commit 27020b2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
- Coverage   34.61%   32.45%   -2.17%     
==========================================
  Files          52       92      +40     
  Lines        2981     9681    +6700     
  Branches     1855     6511    +4656     
==========================================
+ Hits         1032     3142    +2110     
- Misses        310      772     +462     
- Partials     1639     5767    +4128     
Flag Coverage Δ
unittests 32.45% <35.16%> (-2.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.23% <ø> (-1.48%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.16% <ø> (-6.47%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.53% <ø> (ø)
... and 69 more

... and 19 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit e8cfc0e into ros-controls:master May 26, 2023
1 check passed
@fmauch fmauch deleted the fix_readme_branches branch May 27, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants