-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a broadcaster for range sensor #1091
add a broadcaster for range sensor #1091
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 34.61% 32.41% -2.21%
==========================================
Files 52 94 +42
Lines 2981 9937 +6956
Branches 1855 6694 +4839
==========================================
+ Hits 1032 3221 +2189
- Misses 310 789 +479
- Partials 1639 5927 +4288
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Concerning red CI: You (or the maintainers) can merge (or rebase) the master branch into this PR, this should fix the linter jobs.
I think the copyright owner is missing, and the linter might complain.
Up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I marked it for backporting to humble too |
(cherry picked from commit bcdc5bb)
Adding controller_interface/include/semantic_components/range_sensor.hpp
needed for : ros-controls/ros2_controllers#725