Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deactivate hardware from read/write return value (backport #884) #1137

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2023

This is an automatic backport of pull request #884 done by Mergify.
Cherry-pick of bd6911d has failed:

On branch mergify/bp/humble/pr-884
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit bd6911d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hardware_interface/CMakeLists.txt
	modified:   hardware_interface/include/hardware_interface/types/hardware_interface_return_values.hpp
	new file:   ros2_control_test_assets/include/ros2_control_test_assets/test_hardware_interface_constants.hpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   controller_manager/test/test_controller_manager_hardware_error_handling.cpp
	both modified:   hardware_interface/src/resource_manager.cpp
	both modified:   hardware_interface/test/test_components/test_actuator.cpp
	both modified:   hardware_interface/test/test_components/test_system.cpp
	both modified:   hardware_interface/test/test_resource_manager.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

)

* Deactivate hardware from read/write return value
* Added tests to DEACTIVATE return value
* Use constants for defining of special test-values for different HW behaviors

---------

Co-authored-by: Dr. Denis <[email protected]>
(cherry picked from commit bd6911d)

# Conflicts:
#	controller_manager/test/test_controller_manager_hardware_error_handling.cpp
#	hardware_interface/src/resource_manager.cpp
#	hardware_interface/test/test_components/test_actuator.cpp
#	hardware_interface/test/test_components/test_system.cpp
#	hardware_interface/test/test_resource_manager.cpp
Copy link
Contributor Author

mergify bot commented Dec 10, 2023

This pull request is in conflict. Could you fix it @mergify[bot]?

Copy link
Contributor Author

mergify bot commented Jan 29, 2024

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich?

@bmagyar bmagyar closed this Jan 29, 2024
@mergify mergify bot deleted the mergify/bp/humble/pr-884 branch January 29, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants