-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spawner to accept controllers list and start them in sequence (backport #1139) #1149
Conversation
<<<<<<< HEAD | ||
======= | ||
parser.add_argument("controller_names", help="Name of the controller", nargs="+") | ||
>>>>>>> 4e78813 (Update spawner to accept controllers list and start them in sequence (#1139)) | ||
parser.add_argument( | ||
'controller_name', help='Name of the controller') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<<<<<<< HEAD | |
======= | |
parser.add_argument("controller_names", help="Name of the controller", nargs="+") | |
>>>>>>> 4e78813 (Update spawner to accept controllers list and start them in sequence (#1139)) | |
parser.add_argument( | |
'controller_name', help='Name of the controller') | |
parser.add_argument("controller_names", help="Name of the controller", nargs="+") |
<<<<<<< HEAD | ||
prefixed_controller_name = controller_name | ||
if controller_namespace: | ||
prefixed_controller_name = controller_namespace + '/' + controller_name | ||
|
||
node = Node('spawner_' + controller_name) | ||
if not controller_manager_name.startswith('/'): | ||
======= | ||
node = Node("spawner_" + controller_names[0]) | ||
|
||
if not controller_manager_name.startswith("/"): | ||
>>>>>>> 4e78813 (Update spawner to accept controllers list and start them in sequence (#1139)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<<<<<<< HEAD | |
prefixed_controller_name = controller_name | |
if controller_namespace: | |
prefixed_controller_name = controller_namespace + '/' + controller_name | |
node = Node('spawner_' + controller_name) | |
if not controller_manager_name.startswith('/'): | |
======= | |
node = Node("spawner_" + controller_names[0]) | |
if not controller_manager_name.startswith("/"): | |
>>>>>>> 4e78813 (Update spawner to accept controllers list and start them in sequence (#1139)) | |
node = Node("spawner_" + controller_names[0]) | |
if not controller_manager_name.startswith("/"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a missing arg stopped
, rest LGTM
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
good catch, thank you! |
This is an automatic backport of pull request #1139 done by Mergify.
Cherry-pick of 4e78813 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com