[MockHardware] Fix the issues where hardware with multiple interfaces can not be started because of a logical bug added when adding dynamics calculation functionality. #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
===========================================
- Coverage 47.57% 31.46% -16.12%
===========================================
Files 41 94 +53
Lines 3449 10937 +7488
Branches 1873 7507 +5634
===========================================
+ Hits 1641 3441 +1800
- Misses 482 805 +323
- Partials 1326 6691 +5365
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…rted because of a logical bug added when adding dynamics calculation functionality.
bmagyar
approved these changes
Nov 6, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_control
that referenced
this pull request
Nov 16, 2023
…terfaces can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151)" This reverts commit 8bf1a8a.
|
@destogl Could you please backport this to humble branch? The mentioned issue affect the latest Humble ros2_control binary release |
JafarAbdi
pushed a commit
to JafarAbdi/ros2_control
that referenced
this pull request
Nov 23, 2023
… can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151) Co-authored-by: Bence Magyar <[email protected]>
bmagyar
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
… can not be started because of a logical bug added when adding dynamics calculation functionality. (#1151) Co-authored-by: Bence Magyar <[email protected]> (cherry picked from commit 8bf1a8a)
bmagyar
pushed a commit
that referenced
this pull request
Nov 23, 2023
… can not be started because of a logical bug added when adding dynamics calculation functionality. (#1151) (#1178) Co-authored-by: Bence Magyar <[email protected]> (cherry picked from commit 8bf1a8a) Co-authored-by: Dr. Denis <[email protected]>
christophfroehlich
added a commit
to christophfroehlich/ros2_control
that referenced
this pull request
Nov 28, 2023
…terfaces can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151)" This reverts commit 8bf1a8a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144.
I have introduces this bug. The issues is that if one is not using dynamic calculations there is no limitation on interfaces used.
I have also added a test to avoid this hapening again.