Fix the controller sorting bug when the interfaces are not configured (fixes #1164) #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
duringhof,
erickisos,
malapatiravi and
peterdavidfagan
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
- Coverage 47.65% 47.64% -0.01%
==========================================
Files 40 40
Lines 3435 3442 +7
Branches 1860 1865 +5
==========================================
+ Hits 1637 1640 +3
Misses 480 480
- Partials 1318 1322 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
added
backport-humble
|
Thank you for letting us know @fmauch |
|
@bmagyar Since the Humble sync is around the corner: Could we get this merged to Humble with priority? I posted a comment on the sync announcement about this. |
bmagyar
pushed a commit
that referenced
this pull request
Nov 14, 2023
…fixes #1164) (#1165) (#1166) (cherry picked from commit 75e7efd) Co-authored-by: Sai Kishor Kothakota <[email protected]>
bmagyar
pushed a commit
that referenced
this pull request
Nov 14, 2023
…fixes #1164) (#1165) (#1167) (cherry picked from commit 75e7efd) Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Updates the tests to throw the exception on_configure as usual and then fixes with the appropriate condition checks to prevent the case mentioned in the #1164