-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update list of reviewers #1195
Merged
bmagyar
merged 1 commit into
ros-controls:master
from
christophfroehlich:ci/reviewer_lottery
Dec 11, 2023
Merged
[CI] Update list of reviewers #1195
bmagyar
merged 1 commit into
ros-controls:master
from
christophfroehlich:ci/reviewer_lottery
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
harderthan,
peterdavidfagan and
progtologist
December 6, 2023 19:13
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 47.63% 47.63%
=======================================
Files 40 40
Lines 3445 3445
Branches 1866 1866
=======================================
Hits 1641 1641
Misses 480 480
Partials 1324 1324
Flags with carried forward coverage won't be shown. Click here to find out more. |
destogl
approved these changes
Dec 10, 2023
destogl
force-pushed
the
ci/reviewer_lottery
branch
from
December 11, 2023 17:40
2bb40a1
to
f22a510
Compare
bmagyar
approved these changes
Dec 11, 2023
christophfroehlich
added
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
backport-iron
labels
Dec 12, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
(cherry picked from commit 345e70f) # Conflicts: # .github/reviewer-lottery.yml
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
(cherry picked from commit 345e70f)
destogl
pushed a commit
that referenced
this pull request
Dec 12, 2023
(cherry picked from commit 345e70f) Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
added a commit
that referenced
this pull request
Dec 12, 2023
* Update list of reviewers (#1195) (cherry picked from commit 345e70f) # Conflicts: # .github/reviewer-lottery.yml * Update reviewer-lottery.yml --------- Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a python script parsing closed reviews of a repository and making some statistics:
reviewers_ros-controls_ros2_control_2023-12-04.csv
Thanks for the work of lots of active reviewers!
But to make that process more efficient, I removed all reviewers from the list which
a) never finished any review
b) haven't reviewed anything in 2023
Additionally, I promote the following reviewers having already more than approx. 10 reviews and being still active :)
@fmauch
@moriarty
@olivier-stasse
@saikishor
(I think they have to be added to the organisation as well)