Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update list of reviewers #1195

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

christophfroehlich
Copy link
Contributor

I created a python script parsing closed reviews of a repository and making some statistics:
reviewers_ros-controls_ros2_control_2023-12-04.csv

Thanks for the work of lots of active reviewers!

But to make that process more efficient, I removed all reviewers from the list which
a) never finished any review
b) haven't reviewed anything in 2023

Additionally, I promote the following reviewers having already more than approx. 10 reviews and being still active :)
@fmauch
@moriarty
@olivier-stasse
@saikishor
(I think they have to be added to the organisation as well)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1195 (2bb40a1) into master (b8ba5c0) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head 2bb40a1 differs from pull request most recent head f22a510. Consider uploading reports for the commit f22a510 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1195   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files          40       40           
  Lines        3445     3445           
  Branches     1866     1866           
=======================================
  Hits         1641     1641           
  Misses        480      480           
  Partials     1324     1324           
Flag Coverage Δ
unittests 47.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@destogl destogl force-pushed the ci/reviewer_lottery branch from 2bb40a1 to f22a510 Compare December 11, 2023 17:40
@bmagyar bmagyar merged commit 345e70f into ros-controls:master Dec 11, 2023
10 of 12 checks passed
@christophfroehlich christophfroehlich deleted the ci/reviewer_lottery branch December 11, 2023 18:36
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Dec 12, 2023
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 345e70f)

# Conflicts:
#	.github/reviewer-lottery.yml
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 345e70f)
destogl pushed a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 345e70f)

Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich added a commit that referenced this pull request Dec 12, 2023
* Update list of reviewers (#1195)

(cherry picked from commit 345e70f)

# Conflicts:
#	.github/reviewer-lottery.yml

* Update reviewer-lottery.yml

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants