[ResourceManager] adds test for uninitialized hardware #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
erickisos,
peterdavidfagan,
progtologist and
VanshGehlot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
+ Coverage 47.82% 48.05% +0.23%
==========================================
Files 40 40
Lines 3448 3448
Branches 1869 1869
==========================================
+ Hits 1649 1657 +8
+ Misses 456 445 -11
- Partials 1343 1346 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit 64c9e2a)
taDachs
deleted the
issue-1078-add-test-when-hardware-components-can-not-be-initialized
branch
bmagyar
pushed a commit
that referenced
this pull request
Jan 4, 2024
|
@bmagyar no humble backport? |
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
(cherry picked from commit 64c9e2a)
bmagyar
pushed a commit
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two tests for uninitialized hardware as mentioned in #1078 . One that expect an exception being thrown when loading a urdf with validation and one for checking that no state or command interfaces have been added (without validation).
To make hardware "uninitilizable" I used a custom actuator, sensor and system.