controller_manager: Add space to string literal concatenation #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
christophfroehlich,
destogl,
moriarty,
saikishor and
VanshGehlot
There is no space between the string literals, "following" and "controllers". This results in "followingcontrollers", which is not what we want. Add a space to the first string to fix this. Signed-off-by: Yasushi SHOJI <[email protected]>
yashi
force-pushed
the
add-space-between-string-literals
branch
from
25e41d5 to
3cc4fdd
Compare
christophfroehlich
approved these changes
Dec 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
=======================================
Coverage 47.82% 47.82%
=======================================
Files 40 40
Lines 3448 3448
Branches 1869 1869
=======================================
Hits 1649 1649
Misses 456 456
Partials 1343 1343
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Dec 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
(cherry picked from commit 0a7b149)
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 29, 2023
(cherry picked from commit 0a7b149)
bmagyar
pushed a commit
that referenced
this pull request
Dec 30, 2023
roscan-tech
pushed a commit
to roscan-tech/ros2_control
that referenced
this pull request
Sep 8, 2024
…ntrols#1245) Signed-off-by: roscan-tech <[email protected]>
6 tasks
bmagyar
pushed a commit
that referenced
this pull request
Sep 8, 2024
…#1747) Signed-off-by: roscan-tech <[email protected]> Co-authored-by: Yasushi SHOJI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no space between the string literals, "following" and "controllers". This results in "followingcontrollers", which is not what we want.
Add a space to the first string to fix this.