Move test_components to own package
#1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
together with tests of hardware_interface package, to break circular dependency
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl,
olivier-stasse,
saikishor and
VanshGehlot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
- Coverage 48.02% 45.61% -2.42%
==========================================
Files 41 41
Lines 3525 3523 -2
Branches 1912 1912
==========================================
- Hits 1693 1607 -86
- Misses 442 556 +114
+ Partials 1390 1360 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
saikishor
approved these changes
Jan 25, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
(cherry picked from commit 0bdcd41) # Conflicts: # .github/workflows/ci-coverage-build.yml # controller_manager/package.xml # hardware_interface/CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
(cherry picked from commit 0bdcd41)
|
@christophfroehlich can we get these tests separated for Iron and Humble too? |
destogl
added a commit
that referenced
this pull request
Jan 26, 2024
* Move `test_components` to own package (#1325) (cherry picked from commit 0bdcd41) --------- Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Dr. Denis <[email protected]>
destogl
added a commit
that referenced
this pull request
Jan 26, 2024
* Move `test_components` to own package (#1325) (cherry picked from commit 0bdcd41) --------- Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Dr. Denis Štogl <[email protected]>
I think so, because the original problem was with humble binary releases? |
|
It was Iron. I think it's enough to backport there
…On Fri, 26 Jan 2024, 17:05 Christoph Fröhlich, ***@***.***> wrote:
@christophfroehlich <https://github.com/christophfroehlich> can we get
these tests separated for Iron and Humble too?
I think so, because the original problem was with humble binary releases?
—
Reply to this email directly, view it on GitHub
<#1325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA24PYIPVPX6VLPE4SJNDLLYQPO6TAVCNFSM6AAAAABCF6TYGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGM4TCOBTGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
test_componentsto their own package, together with tests of hardware_interface package relying on it to break circular dependency.We decided this in the WG meeting 2024 01 17
This will fix #1285 after we change the test-dependency of the ros2_controllers.