-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHEL-CI] Source underlay with generate_parameter_library #1338
[RHEL-CI] Source underlay with generate_parameter_library #1338
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
=======================================
Coverage 47.53% 47.53%
=======================================
Files 41 41
Lines 3549 3549
Branches 1931 1931
=======================================
Hits 1687 1687
Misses 459 459
Partials 1403 1403
Flags with carried forward coverage won't be shown. Click here to find out more. |
Should RHEL CI still fail? |
well now it fails with compiling messages 🤷 |
Something is broken with the |
Happy to leave this PR open for the empy fixes too? I don't see a point of a merge train which will need another merge train to really fix |
08c0314
to
a8b05a2
Compare
The RHEL job builds now rather fine, but there are consistently flaky segfaulting tests @bmagyar @destogl IMHO this is not related to this PR any more, but a general issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be fair and in line with the Docker image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the summary
generate_parameter_library is necessary for #971, and somehow it is not released for RHEL: This project is currently disabled
For build details see
https://github.com/ros-controls/ros2_rhel/blob/7bfd5933856388cbfee493e1805b6d95cfee32f6/Dockerfile.rhel9#L49-L61
https://github.com/ros-controls/ros2_rhel/blame/7bfd5933856388cbfee493e1805b6d95cfee32f6/Dockerfile.rhel8#L33-L46