Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHEL-CI] Source underlay with generate_parameter_library #1338

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b5f332) 47.53% compared to head (a8b05a2) 47.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1338   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files          41       41           
  Lines        3549     3549           
  Branches     1931     1931           
=======================================
  Hits         1687     1687           
  Misses        459      459           
  Partials     1403     1403           
Flag Coverage Δ
unittests 47.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@destogl
Copy link
Member

destogl commented Jan 25, 2024

Should RHEL CI still fail?

bmagyar
bmagyar previously approved these changes Jan 25, 2024
@bmagyar
Copy link
Member

bmagyar commented Jan 25, 2024

well now it fails with compiling messages 🤷

@christophfroehlich
Copy link
Contributor Author

well now it fails with compiling messages 🤷

Something is broken with the empy module, I had to fix it to a certain version and thought I tried it locally. I'll work on that again next week..

@bmagyar
Copy link
Member

bmagyar commented Jan 28, 2024

Happy to leave this PR open for the empy fixes too? I don't see a point of a merge train which will need another merge train to really fix

@christophfroehlich
Copy link
Contributor Author

The RHEL job builds now rather fine, but there are consistently flaky segfaulting tests ResourceManagerTest.initialization_with_wrong_urdf or ResourceManagerTest.load_urdf_called_if_urdf_is_invalid, see here with ubuntu semi-binary build. I was able to reproduce this locally without giving an explicit build type to colcon, but in the CI it also fails with rel-with-deb-info.

@bmagyar @destogl IMHO this is not related to this PR any more, but a general issue.

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fair and in line with the Docker image.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the summary

@bmagyar bmagyar merged commit 786d5b5 into ros-controls:master Feb 2, 2024
15 of 16 checks passed
@christophfroehlich christophfroehlich deleted the ci_rhel_underlay branch February 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants