Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_components to own package (backport #1325) #1340

Merged
merged 4 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci-coverage-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ jobs:
controller_manager
controller_manager_msgs
hardware_interface
<<<<<<< HEAD
ros2controlcli
ros2_control
ros2_control_test_assets
=======
hardware_interface_testing
>>>>>>> 0bdcd41 (Move `test_components` to own package (#1325))
destogl marked this conversation as resolved.
Show resolved Hide resolved
transmission_interface

vcs-repo-file-url: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci-ros-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
controller_manager
controller_manager_msgs
hardware_interface
hardware_interface_testing
ros2controlcli
ros2_control
ros2_control_test_assets
Expand All @@ -49,6 +50,7 @@ jobs:
controller_manager
controller_manager_msgs
hardware_interface
hardware_interface_testing
ros2controlcli
ros2_control
ros2_control_test_assets
Expand Down
5 changes: 5 additions & 0 deletions controller_manager/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
<depend>std_msgs</depend>

<test_depend>ament_cmake_gmock</test_depend>
<<<<<<< HEAD
=======
<test_depend>hardware_interface_testing</test_depend>
<test_depend>ros2_control_test_assets</test_depend>
>>>>>>> 0bdcd41 (Move `test_components` to own package (#1325))
destogl marked this conversation as resolved.
Show resolved Hide resolved

<export>
<build_type>ament_cmake</build_type>
Expand Down
6 changes: 6 additions & 0 deletions hardware_interface/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ if(BUILD_TESTING)
target_link_libraries(test_component_parser ${PROJECT_NAME})
ament_target_dependencies(test_component_parser ros2_control_test_assets)

<<<<<<< HEAD
add_library(test_components SHARED
test/test_components/test_actuator.cpp
test/test_components/test_sensor.cpp
Expand All @@ -151,6 +152,8 @@ if(BUILD_TESTING)
pluginlib_export_plugin_description_file(
${PROJECT_NAME} test/test_components/test_components.xml)

=======
>>>>>>> 0bdcd41 (Move `test_components` to own package (#1325))
add_library(test_hardware_components SHARED
test/test_hardware_components/test_single_joint_actuator.cpp
test/test_hardware_components/test_force_torque_sensor.cpp
Expand All @@ -167,6 +170,7 @@ if(BUILD_TESTING)
${PROJECT_NAME} test/test_hardware_components/test_hardware_components.xml
)

<<<<<<< HEAD
ament_add_gmock(test_resource_manager test/test_resource_manager.cpp)
target_link_libraries(test_resource_manager ${PROJECT_NAME})
ament_target_dependencies(test_resource_manager ros2_control_test_assets)
Expand All @@ -175,6 +179,8 @@ if(BUILD_TESTING)
target_link_libraries(test_resource_manager_prepare_perform_switch hardware_interface)
ament_target_dependencies(test_resource_manager_prepare_perform_switch ros2_control_test_assets)

=======
>>>>>>> 0bdcd41 (Move `test_components` to own package (#1325))
ament_add_gmock(test_generic_system test/mock_components/test_generic_system.cpp)
target_include_directories(test_generic_system PRIVATE include)
target_link_libraries(test_generic_system ${PROJECT_NAME})
Expand Down
46 changes: 46 additions & 0 deletions hardware_interface_testing/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
cmake_minimum_required(VERSION 3.16)
project(hardware_interface_testing LANGUAGES CXX)

if(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Clang)")
add_compile_options(-Wall -Wextra -Werror=conversion -Werror=unused-but-set-variable -Werror=return-type -Werror=shadow)
endif()

set(THIS_PACKAGE_INCLUDE_DEPENDS
control_msgs
hardware_interface
lifecycle_msgs
pluginlib
rclcpp_lifecycle
ros2_control_test_assets
)

find_package(ament_cmake REQUIRED)
foreach(Dependency IN ITEMS ${THIS_PACKAGE_INCLUDE_DEPENDS})
find_package(${Dependency} REQUIRED)
endforeach()

add_library(test_components SHARED
test/test_components/test_actuator.cpp
test/test_components/test_sensor.cpp
test/test_components/test_system.cpp)
ament_target_dependencies(test_components hardware_interface pluginlib ros2_control_test_assets)
install(TARGETS test_components
DESTINATION lib
)
pluginlib_export_plugin_description_file(
hardware_interface test/test_components/test_components.xml)

if(BUILD_TESTING)

find_package(ament_cmake_gmock REQUIRED)

ament_add_gmock(test_resource_manager test/test_resource_manager.cpp)
ament_target_dependencies(test_resource_manager hardware_interface ros2_control_test_assets)

ament_add_gmock(test_resource_manager_prepare_perform_switch test/test_resource_manager_prepare_perform_switch.cpp)
ament_target_dependencies(test_resource_manager_prepare_perform_switch hardware_interface ros2_control_test_assets)

endif()

ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS})
ament_package()
4 changes: 4 additions & 0 deletions hardware_interface_testing/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# hardware_interface_testing

This package contains a set of hardware interfaces and controllers that can be used for other
packages to test their functionality.
25 changes: 25 additions & 0 deletions hardware_interface_testing/package.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?xml version="1.0"?>
<package format="2">
<name>hardware_interface_testing</name>
<version>0.0.0</version>
<description>ros2_control hardware interface testing</description>
<maintainer email="[email protected]">Bence Magyar</maintainer>
<maintainer email="[email protected]">Denis Štogl</maintainer>
<maintainer email="[email protected]">Christoph Froehlich</maintainer>
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>

<depend>control_msgs</depend>
<depend>hardware_interface</depend>
<depend>lifecycle_msgs</depend>
<depend>pluginlib</depend>
<depend>rclcpp_lifecycle</depend>
<depend>ros2_control_test_assets</depend>

<test_depend>ament_cmake_gmock</test_depend>

<export>
<build_type>ament_cmake</build_type>
</export>
</package>
Loading