Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused joint_limits_interface package #1353

Merged

Conversation

saikishor
Copy link
Member

After #1339, I don't think there are remaining things to migrate from the colon ignored package joint_limits_interface. I believe, this is the good moment for the cleanup

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db11077) 47.53% compared to head (f38ce74) 47.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files          41       41           
  Lines        3549     3549           
  Branches     1931     1931           
=======================================
  Hits         1687     1687           
  Misses        459      459           
  Partials     1403     1403           
Flag Coverage Δ
unittests 47.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like clean-ups ;)

@bmagyar bmagyar merged commit 5b5f332 into ros-controls:master Feb 1, 2024
16 of 17 checks passed
@saikishor saikishor deleted the remove_joint_limits_interface_pkg branch August 17, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants