Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guides and add release notes for Jazzy #1477

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 8, 2024

I scanned the changelogs of this repo and added some highlights to the migration notes for Jazzy.

In the last WG meeting, we decided to split the detailed release notes with the mandatory migration steps. The latter, should be mandatory for future PRs IMHO.

Feel free to comment on missing stuff, and also if you have suggestions for a better format of the list.

needs ros-controls/control.ros.org#265 to be merged afterwards.

Release notes

image

Migration steps

image

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

doc/migration/Iron.rst Outdated Show resolved Hide resolved
doc/migration/Iron.rst Outdated Show resolved Hide resolved
doc/migration/Iron.rst Outdated Show resolved Hide resolved
doc/migration/Iron.rst Outdated Show resolved Hide resolved
doc/migration/Iron.rst Outdated Show resolved Hide resolved
@christophfroehlich christophfroehlich marked this pull request as draft April 15, 2024 16:57
@christophfroehlich christophfroehlich marked this pull request as ready for review April 15, 2024 20:58
@christophfroehlich christophfroehlich changed the title Update migration notes for Jazzy Update migration guides and add release notes for Jazzy Apr 15, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.67%. Comparing base (16fbde3) to head (c55bc1e).
Report is 3 commits behind head on master.

❗ Current head c55bc1e differs from pull request most recent head 86a80a4. Consider uploading reports for the commit 86a80a4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   62.67%   62.67%           
=======================================
  Files          96       96           
  Lines       11311    11311           
  Branches     8151     8151           
=======================================
  Hits         7089     7089           
  Misses        715      715           
  Partials     3507     3507           
Flag Coverage Δ
unittests 62.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christophfroehlich
Copy link
Contributor Author

needs ros-controls/control.ros.org#300 to be merged afterwards

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 2b53c66 into master Apr 29, 2024
2 of 11 checks passed
@christophfroehlich christophfroehlich deleted the update_migration_notes branch April 29, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants