Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc page about joint kinematics (backport #1497) #1559

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 2, 2024

I summarized some results of discussions about mimic joints and how I understand that.
Note, this is different than implemented currently with

for (const auto & mimic_joint : info_.mimic_joints)
{
for (auto i = 0u; i < joint_states_.size(); ++i)
{
joint_states_[i][mimic_joint.joint_index] =
mimic_joint.offset +
mimic_joint.multiplier * joint_states_[i][mimic_joint.mimicked_joint_index];
}
}

This came from the time where we defined the mimic joints in the ros2_control tag. IMHO, it does not make sense now using the URDF-specification, where the behavior of the mimic joint changes by switching the command interface from position to velocity, because we use the offset and calculate
velocity = multiplier * other_joint_velocity + offset

Also related to ros-controls/gazebo_ros2_control#297 and ros-controls/gz_ros2_control#276

I also included transmission interfaces, to give an overview what they are and what they aren't (they were not mentioned once in the docs).


This is an automatic backport of pull request #1497 done by [Mergify](https://mergify.com).

---------

Co-authored-by: Sai Kishor Kothakota <[email protected]>
(cherry picked from commit e122f71)
@christophfroehlich christophfroehlich merged commit 3ec3c43 into humble Jun 2, 2024
4 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1497 branch June 2, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant