[rqt_controller_manager] Add hardware components (backport #1455) #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1586 +/- ##
==========================================
+ Coverage 62.29% 62.31% +0.01%
==========================================
Files 105 105
Lines 11319 11319
Branches 7933 7933
==========================================
+ Hits 7051 7053 +2
+ Misses 809 807 -2
Partials 3459 3459
Flags with carried forward coverage won't be shown. Click here to find out more. |
christophfroehlich
previously approved these changes
Jun 25, 2024
(cherry picked from commit 7ffe1b7)
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-1455
branch
from
f5296d3 to
95494cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #1248 I'd like to add the hardware components to the rqt_controller_manger.
It could also be a different rqt window, but if it is all in one we have the benefit of advertising hardware component lifecycles too.
Tooltip
It includes #1454 and #1447, but I hope they will get merged earlier.
This is an automatic backport of pull request #1455 done by Mergify.