-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Creation of Handles in HW, Adding Getters/Setters (variant support) #1688
Merged
bmagyar
merged 23 commits into
ros-controls:master
from
StoglRobotics-forks:hardware_interfaces_getter_setter
Sep 26, 2024
Merged
Changes from 9 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a2dfd76
split hw related changes from #1240
mamueluth dc1d1d5
Merge branch 'master' into hardware_interfaces_getter_setter
mamueluth 7bb89bc
add orderd vector of StateInterfaces and CommandInterfaces
mamueluth c073b31
Make compileable after splittin
mamueluth 70c674c
Merge branch 'master' into hardware_interfaces_getter_setter
mamueluth 7f24010
Merge branch 'master' into hardware_interfaces_getter_setter
mamueluth cc112c0
Merge branch 'master' into hardware_interfaces_getter_setter
mamueluth 132a5e3
review suggestions
mamueluth 0a61ac5
make compileable
mamueluth 786d03c
Merge branch 'master' into hardware_interfaces_getter_setter
bmagyar 569658e
Introduce type aliases for shared_ptr CommandInterface and StateInter…
bmagyar b1e490b
Remove old TODOs
bmagyar 995db63
export_unlisted_state_interface_descriptions()
bmagyar 6a5430f
export_unlisted_command_interface_descriptions()
bmagyar bec9c06
Fix _2() variants in docs
bmagyar a369f96
shorten comments
bmagyar 4c63d28
Remove comments about renaming function
bmagyar 50c7b9e
Apply suggestions from code review
bmagyar f2adeb1
redecorating
bmagyar 334a6c4
refactor add interfaces
bmagyar 9024adc
fix format
bmagyar ef1fa2c
Merge branch 'master' into hardware_interfaces_getter_setter
bmagyar 7423f61
Update hardware_interface/src/resource_manager.cpp
bmagyar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the docs still have the
_2
issueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry about this. I thought i changed it