Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list controller and list hardware components immediately visualize the state. (backport #1606) #1690

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 16, 2024

  1. Colorize the name and state of the hardware component respective to its state.
  2. Colorize the controller name according to its state and make the output more tabular for easier reading.

New output list_hardware_components

Screenshot_20240709_110427-1

New output list_controllers

Screenshot_20240705_212755-1


This is an automatic backport of pull request #1606 done by [Mergify](https://mergify.com).

…ze the state. (#1606)

(cherry picked from commit cce79eb)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/list_hardware_components.py
@mergify mergify bot added the conflicts label Aug 16, 2024
Copy link
Contributor Author

mergify bot commented Aug 16, 2024

Cherry-pick of cce79eb has failed:

On branch mergify/bp/humble/pr-1606
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit cce79eb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/controller_manager/spawner.py
	modified:   ros2controlcli/ros2controlcli/verb/list_controllers.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ros2controlcli/ros2controlcli/verb/list_hardware_components.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.30%. Comparing base (b6bdce9) to head (4441737).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1690   +/-   ##
=======================================
  Coverage   62.30%   62.30%           
=======================================
  Files         105      105           
  Lines       11314    11314           
  Branches     7928     7928           
=======================================
  Hits         7049     7049           
  Misses        806      806           
  Partials     3459     3459           
Flag Coverage Δ
unittests 62.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/controller_manager/spawner.py 73.21% <100.00%> (ø)

@destogl destogl merged commit 19c52a6 into humble Aug 16, 2024
10 of 11 checks passed
@destogl destogl deleted the mergify/bp/humble/pr-1606 branch August 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant