-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parse_state_interface_descriptions and parse_command_interface_description and reuse components #1768
Merged
bmagyar
merged 3 commits into
ros-controls:master
from
pal-robotics-forks:cleanup/importing_component_interface_description
Nov 16, 2024
Merged
add parse_state_interface_descriptions and parse_command_interface_description and reuse components #1768
bmagyar
merged 3 commits into
ros-controls:master
from
pal-robotics-forks:cleanup/importing_component_interface_description
Nov 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
fmauch,
livanov93,
mcbed and
olivier-stasse
September 26, 2024 19:06
…scriptions to import the components
saikishor
force-pushed
the
cleanup/importing_component_interface_description
branch
from
September 26, 2024 19:35
b185a02
to
b3ea566
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1768 +/- ##
==========================================
+ Coverage 86.90% 86.92% +0.01%
==========================================
Files 118 118
Lines 11438 11423 -15
Branches 1051 1047 -4
==========================================
- Hits 9940 9929 -11
+ Misses 1131 1129 -2
+ Partials 367 365 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
requested review from
christophfroehlich,
peterdavidfagan and
progtologist
September 26, 2024 19:54
christophfroehlich
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saikishor
force-pushed
the
cleanup/importing_component_interface_description
branch
from
October 8, 2024 08:47
f819ef2
to
62e98b9
Compare
bmagyar
reviewed
Oct 8, 2024
bmagyar
approved these changes
Nov 16, 2024
saikishor
deleted the
cleanup/importing_component_interface_description
branch
November 16, 2024 16:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in yesterday's WG meeting, as the #1688 is merged, we would like to modify the import_state_interface_descriptions and import_command_interface_descriptions instead of parsing the hardware info to them, we parse the hardware_info_.joints and hardware_info_.sensors and it imports accordingly etc
Fixes: #1766