Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] Handle simulation environment clocks #1810

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Oct 24, 2024

As there are many ongoing issues that people are trying to use the ros2_control_node for the simulation environments and as it is not working, I wanted to see if this solution is something that we are interesting to go with or we simple reject the possibility

Related to : #859

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (98f0795) to head (eb2156a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   88.21%   88.19%   -0.03%     
==========================================
  Files         121      121              
  Lines       12309    12313       +4     
  Branches     1095     1096       +1     
==========================================
+ Hits        10858    10859       +1     
- Misses       1056     1057       +1     
- Partials      395      397       +2     
Flag Coverage Δ
unittests 88.19% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 78.26% <66.66%> (-2.70%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which situations would this be useful? When we have a simulator hardware component that doesn't run its own control node such as Gazebo, right?

@saikishor which issues are related to this PR?

@saikishor
Copy link
Member Author

In which situations would this be useful? When we have a simulator hardware component that doesn't run its own control node such as Gazebo, right?

@saikishor which issues are related to this PR?

@fmauch It seems many are using this node alongside IssacSim or other simulators. We should decide what to do in our next WG meeting, either support it this way or throw an exception that it is not supported to use with simulation.

It is related to #859 and ros-controls/ros2_controllers#537

@saikishor saikishor force-pushed the make/ros2_control_node/generic branch from bb5f0f1 to 1d4f7bf Compare November 4, 2024 21:58
@christophfroehlich christophfroehlich linked an issue Nov 6, 2024 that may be closed by this pull request
@christophfroehlich christophfroehlich merged commit d714e8b into ros-controls:master Nov 6, 2024
17 of 21 checks passed
@saikishor saikishor deleted the make/ros2_control_node/generic branch November 6, 2024 19:10
@bmagyar bmagyar added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Nov 7, 2024
mergify bot pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit d714e8b)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
#	doc/release_notes.rst
mergify bot pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit d714e8b)

# Conflicts:
#	doc/release_notes.rst
saikishor added a commit to pal-robotics-forks/ros2_control that referenced this pull request Nov 7, 2024
saikishor added a commit to pal-robotics-forks/ros2_control that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rate incorrect if using sim time
4 participants