-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2_control_node] Handle simulation environment clocks #1810
[ros2_control_node] Handle simulation environment clocks #1810
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1810 +/- ##
==========================================
- Coverage 88.21% 88.19% -0.03%
==========================================
Files 121 121
Lines 12309 12313 +4
Branches 1095 1096 +1
==========================================
+ Hits 10858 10859 +1
- Misses 1056 1057 +1
- Partials 395 397 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which situations would this be useful? When we have a simulator hardware component that doesn't run its own control node such as Gazebo, right?
@saikishor which issues are related to this PR?
@fmauch It seems many are using this node alongside IssacSim or other simulators. We should decide what to do in our next WG meeting, either support it this way or throw an exception that it is not supported to use with simulation. It is related to #859 and ros-controls/ros2_controllers#537 |
bb5f0f1
to
1d4f7bf
Compare
d714e8b
into
ros-controls:master
(cherry picked from commit d714e8b) # Conflicts: # controller_manager/src/ros2_control_node.cpp # doc/release_notes.rst
(cherry picked from commit d714e8b) # Conflicts: # doc/release_notes.rst
…-controls#1810)" This reverts commit d714e8b.
As there are many ongoing issues that people are trying to use the ros2_control_node for the simulation environments and as it is not working, I wanted to see if this solution is something that we are interesting to go with or we simple reject the possibility
Related to : #859