Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gmock CMP0115 #1830

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix gmock CMP0115 #1830

merged 1 commit into from
Nov 4, 2024

Conversation

christophfroehlich
Copy link
Contributor

Fixes

--- stderr: controller_manager                                           
CMake Warning (dev) at /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:50 (add_executable):
  Policy CMP0115 is not set: Source file extensions must be explicit.  Run
  "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  File:

    /workspaces/ros2_rolling_ws/src/ros2_control/controller_manager/test/test_hardware_spawner.cpp
Call Stack (most recent call first):
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:37 (_ament_add_gmock_executable)
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock.cmake:65 (ament_add_gmock_executable)
  CMakeLists.txt:197 (ament_add_gmock)
This warning is for project developers.  Use -Wno-dev to suppress it.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (5dbd6d5) to head (5c32b18).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1830   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         121      121           
  Lines       12301    12301           
  Branches     1093     1093           
=======================================
  Hits        10856    10856           
  Misses       1051     1051           
  Partials      394      394           
Flag Coverage Δ
unittests 88.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bmagyar bmagyar added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Nov 4, 2024
@bmagyar bmagyar merged commit 434f7f5 into master Nov 4, 2024
20 checks passed
@bmagyar bmagyar deleted the fix/CMP0115 branch November 4, 2024 18:44
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
(cherry picked from commit 434f7f5)

# Conflicts:
#	controller_manager/CMakeLists.txt
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
(cherry picked from commit 434f7f5)

# Conflicts:
#	controller_manager/CMakeLists.txt
christophfroehlich added a commit that referenced this pull request Nov 10, 2024
bmagyar pushed a commit that referenced this pull request Nov 10, 2024
saikishor pushed a commit to pal-robotics-forks/ros2_control that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants