Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the valid time check in the update loop #1923

Merged

Conversation

saikishor
Copy link
Member

I made small optimization of the recently introduced valid time check, to avoid checking for every controller and to isolate it at one place

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.79%. Comparing base (0ef99fe) to head (5561b95).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   87.75%   87.79%   +0.04%     
==========================================
  Files         122      122              
  Lines       12940    12934       -6     
  Branches     1155     1154       -1     
==========================================
+ Hits        11355    11356       +1     
+ Misses       1159     1154       -5     
+ Partials      426      424       -2     
Flag Coverage Δ
unittests 87.79% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 76.64% <66.66%> (+0.40%) ⬆️

@bmagyar bmagyar merged commit 5e53146 into ros-controls:master Dec 9, 2024
17 of 20 checks passed
@saikishor saikishor deleted the improve/valid_time/check branch December 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants