Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add clang job, setup concurrency, use rt_tools humble branch (backport #1910) #1924

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 8, 2024

  • This adds a semi-binary job using clang. I fixed all what clang was complaining about.
  • use humble branch of realtime_tools for humble CI

Closes #611

Additionally, I added the concurrency settings which now automatically cancel running workflows if anything is pushed to PRs.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs


This is an automatic backport of pull request #1910 done by Mergify.

@mergify mergify bot added the conflicts label Dec 8, 2024
Copy link
Contributor Author

mergify bot commented Dec 8, 2024

Cherry-pick of 6e896bf has failed:

On branch mergify/bp/humble/pr-1910
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 6e896bf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/humble-abi-compatibility.yml
	modified:   .github/workflows/humble-binary-build.yml
	modified:   .github/workflows/humble-check-docs.yml
	modified:   .github/workflows/humble-coverage-build.yml
	modified:   .github/workflows/humble-debian-build.yml
	modified:   .github/workflows/humble-pre-commit.yml
	modified:   .github/workflows/humble-rhel-binary-build.yml
	modified:   .github/workflows/humble-semi-binary-build.yml
	modified:   .github/workflows/jazzy-abi-compatibility.yml
	modified:   .github/workflows/jazzy-binary-build.yml
	modified:   .github/workflows/jazzy-check-docs.yml
	modified:   .github/workflows/jazzy-debian-build.yml
	modified:   .github/workflows/jazzy-pre-commit.yml
	modified:   .github/workflows/jazzy-rhel-binary-build.yml
	modified:   .github/workflows/jazzy-semi-binary-build.yml
	modified:   .github/workflows/rolling-abi-compatibility.yml
	modified:   .github/workflows/rolling-binary-build.yml
	modified:   .github/workflows/rolling-check-docs.yml
	modified:   .github/workflows/rolling-compatibility-humble-binary-build.yml
	modified:   .github/workflows/rolling-compatibility-jazzy-binary-build.yml
	modified:   .github/workflows/rolling-coverage-build.yml
	modified:   .github/workflows/rolling-debian-build.yml
	modified:   .github/workflows/rolling-pre-commit.yml
	modified:   .github/workflows/rolling-semi-binary-build.yml
	modified:   .github/workflows/rosdoc2.yml
	modified:   controller_interface/include/semantic_components/force_torque_sensor.hpp
	modified:   hardware_interface/test/test_macros.cpp
	modified:   ros2_control.humble.repos

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/rolling-rhel-binary-build.yml
	both modified:   controller_interface/src/controller_interface_base.cpp
	both modified:   controller_manager/src/ros2_control_node.cpp
	both modified:   hardware_interface/src/component_parser.cpp
	both modified:   hardware_interface/src/mock_components/generic_system.cpp
	both modified:   hardware_interface/test/test_component_interfaces.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich christophfroehlich linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.01%. Comparing base (e3715c3) to head (d00dc6c).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1924      +/-   ##
==========================================
+ Coverage   62.98%   63.01%   +0.02%     
==========================================
  Files         109      109              
  Lines       12449    12450       +1     
  Branches     8445     8445              
==========================================
+ Hits         7841     7845       +4     
+ Misses        844      842       -2     
+ Partials     3764     3763       -1     
Flag Coverage Δ
unittests 63.01% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/semantic_components/force_torque_sensor.hpp 100.00% <100.00%> (ø)
hardware_interface/src/component_parser.cpp 91.88% <100.00%> (ø)
...e_interface/src/mock_components/generic_system.cpp 80.06% <100.00%> (+0.06%) ⬆️
...dware_interface/test/test_component_interfaces.cpp 50.75% <100.00%> (ø)
hardware_interface/test/test_macros.cpp 68.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 8164fc5 into humble Dec 10, 2024
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1910 branch December 10, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build job humble/testing failed!
1 participant