Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HW errors on read and write in CM by stopping controllers (backport #742) #abi-breaking #838

Closed
wants to merge 8 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2022

This is an automatic backport of pull request #742 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@destogl destogl changed the title Handle HW errors on read and write in CM by stopping controllers (backport #742) Handle HW errors on read and write in CM by stopping controllers (backport #742) #abi-braking Oct 15, 2022
@destogl destogl changed the title Handle HW errors on read and write in CM by stopping controllers (backport #742) #abi-braking Handle HW errors on read and write in CM by stopping controllers (backport #742) #abi-breaking Oct 15, 2022
@bmagyar bmagyar added the humble label Dec 6, 2022
destogl
destogl previously approved these changes Mar 13, 2023
@destogl destogl force-pushed the mergify/bp/humble/pr-742 branch from 69e0d38 to 884ebff Compare March 13, 2023 18:32
bmagyar
bmagyar previously approved these changes Mar 13, 2023
@Benjamin-Tan
Copy link

Would this be merge to humble with breaking ABI check?

@bmagyar
Copy link
Member

bmagyar commented Apr 3, 2023

On a scale of 1-10 how much would that bother you? We'd really like to have this in Humble as it's a good quality of life improvement

@Benjamin-Tan
Copy link

I would like to have this feature in humble even with breaking abi check. My understanding of this breaking abi could be resolved by updating/fixing the relevant code after it is merged to humble. Is my understanding correct?

@destogl
Copy link
Member

destogl commented Apr 11, 2023

I would like to have this feature in humble even with breaking abi check. My understanding of this breaking abi could be resolved by updating/fixing the relevant code after it is merged to humble. Is my understanding correct?

You don't even need to fix the code, but just re-link your libraries. Basically, "recompile" it, beucase compiling and linking is merged togeather with colcon

@destogl destogl force-pushed the mergify/bp/humble/pr-742 branch from 5de258d to 64818dd Compare April 11, 2023 17:47
@Benjamin-Tan
Copy link

Benjamin-Tan commented Apr 12, 2023

I see. In this case, I think having this feature available in humble (current LTS release) is an easy decision and a clear winner over holding it. What do you think?

@Benjamin-Tan
Copy link

Any thoughts/comments on this PR from the reviewers?

bmagyar
bmagyar previously approved these changes Apr 30, 2023
@Benjamin-Tan
Copy link

Could the reviewers give this a look and drop your feedback for not approving it?

destogl and others added 2 commits August 9, 2023 19:41
Add code for deactivating controller when hardware gets an error on read and write.
Fix misleading variable name in the tests.
Remove all interface from available list for hardware when an error happens.
Do some more variable renaming to the new nomenclature.

(cherry picked from commit ecf6c69)
@destogl destogl force-pushed the mergify/bp/humble/pr-742 branch from 64818dd to 1be9390 Compare August 9, 2023 17:41
@mateusmenezes95
Copy link
Contributor

Hello @bmagyar and @destogl. I hope you are well

We are using the ros2_control in the ROS Humble version in our project and are facing a problem that the modification in #742 will solve. Unfortunately, we can not upgrade our system for the last ROS 2 stable release. Hence, we need this feature in the Humble version.

Therefore, do you have some schedule estimation of when this backporting will occur? While this does not happen, do you have any suggestions on how we can handle the hardware component read/write failure for now?

In addition, I am available to help you if necessary!

@mateusmenezes95
Copy link
Contributor

Hi there, just checking in – any updates on this PR?

Copy link
Contributor Author

mergify bot commented Nov 14, 2023

This pull request is in conflict. Could you fix it @mergify[bot]?

@bmagyar
Copy link
Member

bmagyar commented Nov 14, 2023 via email

@christophfroehlich
Copy link
Contributor

needs #1191 first

@christophfroehlich christophfroehlich marked this pull request as draft December 10, 2023 21:47
Copy link
Contributor Author

mergify bot commented Jan 29, 2024

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich?

@bmagyar
Copy link
Member

bmagyar commented Mar 13, 2024

It is too late to merge this PR to Humble at this stage.
That being said, we now support building the master branch from source on Humble so you can have this and even more features!

@bmagyar bmagyar closed this Mar 13, 2024
@mergify mergify bot deleted the mergify/bp/humble/pr-742 branch March 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants