Sort chained controllers #877
Conversation
github-actions
bot
requested review from
anfemosa,
aprotyas,
bmagyar,
DasRoteSkelett,
destogl,
mhubii and
Serafadam
github-actions
bot
requested review from
harderthan,
jaron-l,
LukasMacha97,
progtologist and
rosterloh
|
@sgmurray can you please contact me somehow? I was sending you Email but you didn't answer... |
| // new value: "START_DOWNSTREAM_CTRLS" --> start "downstream" controllers in a controllers chain | ||
| // | ||
| TEST_P(TestControllerChainingWithControllerManager, test_chained_controllers_random_order) |
There was a problem hiding this comment.
I'm sorry but I don't get what this test does. It feels like this is testing multiple components and various random things... We should clarify the implementation of this. I don't get why the internal counter check should be different, I don't get why a "random order test" starts with "add all controllers IN RESERVE EXECUTION ORDER" ?? so it's ordered, not random :D
| @@ -489,10 +491,112 @@ controller_interface::return_type ControllerManager::configure_controller( | |||
| return controller_interface::return_type::ERROR; | |||
| } | |||
| resource_manager_->import_controller_reference_interfaces(controller_name, interfaces); | |||
| } | |||
|
|
|||
| std::vector<ControllerSpec> & unused_controller_list = | |||
There was a problem hiding this comment.
this code is very complex as all entangled sorting algo implementations tend to be. I'd prefer if it was in a separate function so it can be unit tested.
|
This pull request is in conflict. Could you fix it @sgmurray? |
|
closing in favour of #1063 |
fix #853