Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlock in ResourceManager #925

Merged

Conversation

cwecht
Copy link
Contributor

@cwecht cwecht commented Jan 25, 2023

This PR fixes a potential deadlock in ResourceManager detected bei TSAN:

grafik

@cwecht cwecht force-pushed the fix_potential_deadlock_in_resource_manager branch from f519218 to 76f27a1 Compare February 8, 2023 12:32
@destogl destogl force-pushed the fix_potential_deadlock_in_resource_manager branch from 76f27a1 to f1a258f Compare February 14, 2023 05:21
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee! I like the change. LGTM

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #925 (e5efa5c) into master (082a66f) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head e5efa5c differs from pull request most recent head 46780c5. Consider uploading reports for the commit 46780c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   31.53%   31.54%   +0.01%     
==========================================
  Files          94       94              
  Lines       10889    10885       -4     
  Branches     7465     7461       -4     
==========================================
  Hits         3434     3434              
  Misses        805      805              
+ Partials     6650     6646       -4     
Flag Coverage Δ
unittests 31.54% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hardware_interface/src/resource_manager.cpp 47.40% <0.00%> (+0.29%) ⬆️

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit d4f464e into ros-controls:master Nov 4, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants