-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log level support to spawner node #972
Add log level support to spawner node #972
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 34.61% 32.77% -1.85%
==========================================
Files 52 91 +39
Lines 2981 9511 +6530
Branches 1855 6408 +4553
==========================================
+ Hits 1032 3117 +2085
- Misses 310 676 +366
- Partials 1639 5718 +4079
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Very clean!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Moreover, great solution for redirecting output of the load_parameter_file
function.
Want to be able to control the output from the spawner node. This PR adds a log-level argument that is set on the spawner node.