Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jazzy tests and other minor workflow changes #83

Merged
merged 9 commits into from
May 18, 2024

Conversation

christophfroehlich
Copy link
Contributor

  • gazebo classic is not released on noble -> gazebo_ros2_control can't be compiled on jazzy/noble
  • reformat README
  • add path filters, run PRs if repos/yaml files have changed

@christophfroehlich christophfroehlich changed the title Fix jazzy tests Fix jazzy tests and other minor workflow changes May 14, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is the failing test normal in the jazzy comparability build?

@christophfroehlich
Copy link
Contributor Author

LGTM, but is the failing test normal in the jazzy comparability build?

main repo fails because nothing is released yet, testing repo fails because of the
"subscription already associated with a wait set" of the ros2_controllers tests (as on rolling itself)

@christophfroehlich christophfroehlich merged commit c950826 into master May 18, 2024
10 of 16 checks passed
@christophfroehlich christophfroehlich deleted the test_jazzy branch May 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants