Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from Foxy to Galactic #138

Merged
merged 8 commits into from
Oct 4, 2021
Merged

Migrating from Foxy to Galactic #138

merged 8 commits into from
Oct 4, 2021

Conversation

destogl
Copy link
Member

@destogl destogl commented Sep 30, 2021

Replaces #137
@liushuya7 sorry I did mistake by force-pushing to your branch and now opened this PR.

@destogl destogl requested a review from bmagyar September 30, 2021 14:05
@destogl
Copy link
Member Author

destogl commented Sep 30, 2021

@bailaC can you also check this one?

@destogl
Copy link
Member Author

destogl commented Sep 30, 2021

Rolling Binary is expected to fail until the ros2_control packages are released.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #138 (016128f) into master (37b1c9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #138    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files           8       4     -4     
  Lines         756     381   -375     
=======================================
+ Misses        756     381   -375     
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rol_demo_hardware/src/rrbot_system_with_sensor.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...rol_demo_hardware/src/rrbot_system_with_sensor.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp 0.00% <0.00%> (ø)
...demo_hardware/src/rrbot_system_multi_interface.cpp 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b1c9c...016128f. Read the comment docs.

Copy link
Contributor

@bailaC bailaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@bmagyar bmagyar merged commit 93aec17 into master Oct 4, 2021
@destogl destogl deleted the liushuya7/master branch October 4, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants