-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example 14] Modular robot with actuators not providing states #334
[Example 14] Modular robot with actuators not providing states #334
Conversation
Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: Jack <[email protected]>
bb4db3c
to
6cdc27e
Compare
...ngup/launch/rrbot_modular_actuators_without_feedback_sensors_for_position_feedback.launch.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment! If OK, feel free to merge.
Co-authored-by: Dr. Denis <[email protected]>
@Mergifyio backport humble |
✅ Backports have been created
|
thanks @destogl, I have fixed that now but github still needs an approving review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart minor details.
The return type for the lambda function is worth to be fixed.
Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Dr. Denis <[email protected]> (cherry picked from commit 90fac3d)
…#367) Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Dr. Denis <[email protected]> (cherry picked from commit 90fac3d) Co-authored-by: Christoph Fröhlich <[email protected]>
This PR is a rebase of #147 onto master, adding it as example 14.