Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example 14] Modular robot with actuators not providing states #334

Merged

Conversation

christophfroehlich
Copy link
Contributor

This PR is a rebase of #147 onto master, adding it as example 14.

destogl
destogl previously approved these changes Sep 18, 2023
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment! If OK, feel free to merge.

example_14/doc/userdoc.rst Outdated Show resolved Hide resolved
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

backport humble

✅ Backports have been created

@christophfroehlich
Copy link
Contributor Author

Just one small comment! If OK, feel free to merge.

thanks @destogl, I have fixed that now but github still needs an approving review :)

Copy link
Collaborator

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart minor details.
The return type for the lambda function is worth to be fixed.

example_14/doc/userdoc.rst Show resolved Hide resolved
@christophfroehlich christophfroehlich merged commit 90fac3d into ros-controls:master Sep 29, 2023
18 checks passed
mergify bot pushed a commit that referenced this pull request Sep 29, 2023
Co-authored-by: Denis Štogl <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
(cherry picked from commit 90fac3d)
@christophfroehlich christophfroehlich deleted the pr147_rebase branch September 29, 2023 06:55
christophfroehlich added a commit that referenced this pull request Sep 29, 2023
…#367)

Co-authored-by: Denis Štogl <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
(cherry picked from commit 90fac3d)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants