Minor fixes in documentation (example_1 and example_12) #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
christophfroehlich,
destogl,
livanov93,
LukasMacha97,
mhubii and
VanshGehlot
olivier-stasse
force-pushed
the
master
branch
from
250522a to
50a9090
Compare
christophfroehlich
approved these changes
Sep 26, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* [example_1/doc] Specify that step 1 is optional. Two in * [example_12/README.md] Fix wrong title in README.md --------- Co-authored-by: Olivier Stasse <[email protected]> (cherry picked from commit 40b92dd)
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 26, 2023
* [example_1/doc] Specify that step 1 is optional. Two in * [example_12/README.md] Fix wrong title in README.md --------- Co-authored-by: Olivier Stasse <[email protected]> (cherry picked from commit 40b92dd) Co-authored-by: Olivier Stasse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing simple stuff on top of the amazing recent work on documenting this repo.
In example 1, the first step is optional and RViz should be closed, and the second step start also RViz. Plus there is two in as some point.
In example 12, the file README.md is giving the wrong title for the example.