-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] reusable workflows from ros2_control_ci #444
Merged
saikishor
merged 5 commits into
ros-controls:master
from
christophfroehlich:ci_reusable_wfs
Feb 17, 2024
Merged
[CI] reusable workflows from ros2_control_ci #444
saikishor
merged 5 commits into
ros-controls:master
from
christophfroehlich:ci_reusable_wfs
Feb 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophfroehlich
commented
Feb 15, 2024
•
edited
Loading
edited
- I moved the reusable workflow files to https://github.com/ros-controls/ros2_control_ci
- Use matrix strategy for main/testing repos
- use reviewer database from ros2_control_ci, see [CI] Use reusable-reviewer-lottery from ros2_control_ci ros2_control#1402
github-actions
bot
requested review from
bmagyar,
erickisos,
jaron-l,
livanov93,
progtologist and
VanshGehlot
February 15, 2024 08:19
Thank you for the changes! |
saikishor
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Use reviewer database from ros2_control_ci * Use industrial_ci from ros2_control_ci * Also update semi-binary workflows * fail-fast: false * Use reviewer lottery from ros2_control_ci (cherry picked from commit c810999)
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Use reviewer database from ros2_control_ci * Use industrial_ci from ros2_control_ci * Also update semi-binary workflows * fail-fast: false * Use reviewer lottery from ros2_control_ci (cherry picked from commit c810999) # Conflicts: # .github/workflows/iron-binary-build.yml # .github/workflows/iron-semi-binary-build.yml # .github/workflows/rolling-binary-build.yml # .github/workflows/rolling-semi-binary-build.yml
This was referenced Feb 17, 2024
christophfroehlich
added a commit
that referenced
this pull request
Feb 17, 2024
* Use reviewer database from ros2_control_ci * Use industrial_ci from ros2_control_ci * Also update semi-binary workflows * fail-fast: false * Use reviewer lottery from ros2_control_ci (cherry picked from commit c810999) Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
added a commit
that referenced
this pull request
Feb 17, 2024
* Use reviewer database from ros2_control_ci * Use industrial_ci from ros2_control_ci * Also update semi-binary workflows * fail-fast: false * Use reviewer lottery from ros2_control_ci (cherry picked from commit c810999) # Conflicts: # .github/workflows/iron-binary-build.yml # .github/workflows/iron-semi-binary-build.yml # .github/workflows/rolling-binary-build.yml # .github/workflows/rolling-semi-binary-build.yml Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.