-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 use pre-commit workflow from ros2_control_ci #458
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophfroehlich
commented
Mar 4, 2024
- use pre-commit workflow from ros2_control_ci (replace old format and lint jobs)
- update pre-commit
- fix contributing.md
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
jaron-l,
peterdavidfagan,
progtologist and
VanshGehlot
March 4, 2024 19:26
progtologist
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
saikishor
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci * Update pre-commit config * Fix license text in contributing.md * Add update-pre-commit (cherry picked from commit 7dc41df) # Conflicts: # .github/workflows/ci-ros-lint.yml
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci * Update pre-commit config * Fix license text in contributing.md * Add update-pre-commit (cherry picked from commit 7dc41df)
christophfroehlich
added a commit
that referenced
this pull request
Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci * Update pre-commit config * Fix license text in contributing.md (cherry picked from commit 7dc41df) Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
added a commit
that referenced
this pull request
Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci * Update pre-commit config * Fix license text in contributing.md * Add update-pre-commit
christophfroehlich
added a commit
that referenced
this pull request
Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci * Update pre-commit config * Fix license text in contributing.md * Add update-pre-commit Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.