[CI] Add path-filters and fix branches for check-docs #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
erickisos,
livanov93,
mcbed and
saikishor
christophfroehlich
changed the title
saikishor
reviewed
May 14, 2024
Comment on lines
+8
to
+17
| paths: | ||
| - '**.hpp' | ||
| - '**.cpp' | ||
| - '.github/workflows/humble-binary-build.yml' | ||
| - '**/package.xml' | ||
| - '**/CMakeLists.txt' | ||
| - '**.xacro' | ||
| - '**.py' | ||
| - '**.yaml' | ||
| - 'ros2_control_demos-not-released.humble.repos' |
There was a problem hiding this comment.
@christophfroehlich are these paths used to check for the changes in the files and then run the CI only if there are changes?
There was a problem hiding this comment.
exactly. if one changes only rst files, we don't run unnecessary CI checks.
There was a problem hiding this comment.
@christophfroehlich Should we add these filters in other repos as well?. In case, we touch only the documentation, so it won't launch the unnecessary CI
There was a problem hiding this comment.
saikishor
approved these changes
May 14, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2024
* Fix branches for check-docs * Fix iron * Add path filters * Include workflow file to paths filter (cherry picked from commit e6543df) # Conflicts: # .github/workflows/iron-check-docs.yml
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2024
* Fix branches for check-docs * Fix iron * Add path filters * Include workflow file to paths filter (cherry picked from commit e6543df)
christophfroehlich
added a commit
that referenced
this pull request
May 14, 2024
* Fix branches for check-docs * Add path filters * Include workflow file to paths filter Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
added a commit
that referenced
this pull request
May 14, 2024
* Fix branches for check-docs * Add path filters * Include workflow file to paths filter (cherry picked from commit e6543df) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollinginstead ofmasterfor the reusable workflow.