Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivate tests for example_15 #546

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Reactivate tests for example_15 #546

merged 2 commits into from
Sep 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jul 29, 2024 •
edited
Loading

Follow-up to #540

Re-evalute after #502 is merged.

@christophfroehlich christophfroehlich mentioned this pull request Jul 29, 2024
Merged
Base automatically changed from add_launch_tests to master July 30, 2024 07:14
@ros-controls ros-controls deleted a comment from mergify bot Jul 30, 2024
@christophfroehlich
Copy link
Contributor Author

@saikishor it seems that we have a bug or a race condition in the spawner:
There is no rrbot_1.spawner_joint_state_broadcaster launched, but two for rrbot_2 with the obvious error
2: [spawner-10] [WARN] [1727282065.051104080] [rrbot_2.spawner_joint_state_broadcaster]: �[93mController already loaded, skipping load_controller�[0m
When I uncomment the rrbot_2_launch here, then the JSB for rrbot_1 is spawned as expected. Any ideas?

@saikishor
Copy link
Member

@saikishor it seems that we have a bug or a race condition in the spawner: There is no rrbot_1.spawner_joint_state_broadcaster launched, but two for rrbot_2 with the obvious error 2: [spawner-10] [WARN] [1727282065.051104080] [rrbot_2.spawner_joint_state_broadcaster]: �[93mController already loaded, skipping load_controller�[0m When I uncomment the rrbot_2_launch here, then the JSB for rrbot_1 is spawned as expected. Any ideas?

Ahh I believe I might know. Both the robots use the same controller manager here?

@christophfroehlich
Copy link
Contributor Author

No, /rrbot_1/controller_manager vs /rrbot_2/controller_manager

@christophfroehlich christophfroehlich marked this pull request as ready for review September 29, 2024 19:40
@christophfroehlich
Copy link
Contributor Author

The problem seemed to be the RegisterEventHandler. We don't need it here for the spawners (or in the demos at all?). Binary build fails until next release of ros2_control.

@christophfroehlich christophfroehlich enabled auto-merge (squash) September 29, 2024 19:41
saikishor
saikishor approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 8796c3b into master Sep 29, 2024
10 of 14 checks passed
@christophfroehlich christophfroehlich deleted the activate_test_15 branch September 29, 2024 20:03
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@christophfroehlich @mergify
Reactivate tests for example_15 (#546)
85ab8db 
* Revert "Deactivate failing tests for example_15"

This reverts commit 0c3c978.

* Remove RegisterEventHandlers

(cherry picked from commit 8796c3b)
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@christophfroehlich @mergify
Reactivate tests for example_15 (#546)
e6bde1e 
* Revert "Deactivate failing tests for example_15"

This reverts commit 0c3c978.

* Remove RegisterEventHandlers

(cherry picked from commit 8796c3b)
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
christophfroehlich added a commit that referenced this pull request Sep 29, 2024
@mergify @christophfroehlich
Reactivate tests for example_15 (#546) (#593)
184efb9 
* Revert "Deactivate failing tests for example_15"

This reverts commit 0c3c978.

* Remove RegisterEventHandlers

(cherry picked from commit 8796c3b)

Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich added a commit that referenced this pull request Sep 29, 2024
@mergify @christophfroehlich
Reactivate tests for example_15 (#546) (#594)
b6666a3 
* Revert "Deactivate failing tests for example_15"

This reverts commit 0c3c978.

* Remove RegisterEventHandlers

(cherry picked from commit 8796c3b)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@fmauch fmauch Awaiting requested review from fmauch

@mamueluth mamueluth Awaiting requested review from mamueluth

@moriarty moriarty Awaiting requested review from moriarty

@progtologist progtologist Awaiting requested review from progtologist

Assignees
No one assigned
Labels
backport-humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @saikishor