Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate assert exit codes #548

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

Follow-up to #540

These are flaky, especially example 14 is making trouble with segfaults of the ros2_control node.

Base automatically changed from add_launch_tests to master July 30, 2024 07:14
@christophfroehlich christophfroehlich force-pushed the activate_assert_exit_codes branch from 6472c32 to dca31ed Compare July 30, 2024 07:43
@ros-controls ros-controls deleted a comment from mergify bot Jul 30, 2024
Copy link
Contributor

mergify bot commented Sep 12, 2024

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich marked this pull request as ready for review February 14, 2025 20:08
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you! :)

@christophfroehlich christophfroehlich merged commit f09c240 into master Feb 18, 2025
11 checks passed
@christophfroehlich christophfroehlich deleted the activate_assert_exit_codes branch February 18, 2025 20:11
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit f09c240)
christophfroehlich added a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit f09c240)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants