Change interface export variant of all examples #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
force-pushed
the
variants
branch
from
c65412c to
24dd3a1
Compare
github-actions
bot
requested review from
DasRoteSkelett,
destogl,
fmauch,
mcbed,
olivier-stasse,
saikishor and
VanshGehlot
Open
bmagyar
reviewed
Dec 4, 2024
bmagyar
reviewed
Dec 4, 2024
bmagyar
reviewed
Dec 4, 2024
example_8/hardware/rrbot_transmissions_system_position_only.cpp
Outdated
Show resolved
Hide resolved
bmagyar
reviewed
Dec 4, 2024
example_8/hardware/rrbot_transmissions_system_position_only.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Bence Magyar <[email protected]>
bmagyar
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the changes of #396 to all the other examples.
The only missing one is example_14, which has a conceptional issue of sensor components not exporting joint interfaces.