-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ex10: use gpio_command_controller
#627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to delete entry of ros2_control_demo_example_10/GPIOController
in the
ros2_control_demo_example_10.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's wait for the next release of ros2_controllers. |
* Remove controller and use upstream one * Fix error messages * Fix last demo section * Use fork for ros2_controllers * Fix CMakeLists and deps * Use upstream ros2_controllers * Update docs with latest changes of controller * Update with new message type * Switch to master branch of ros2_control * Remove old controller from pluginlib xml * Use released ros2_controllers (cherry picked from commit 332ede0) # Conflicts: # example_10/bringup/config/rrbot_controllers.yaml # example_10/package.xml
* Remove controller and use upstream one * Fix error messages * Fix last demo section * Use fork for ros2_controllers * Fix CMakeLists and deps * Use upstream ros2_controllers * Update docs with latest changes of controller * Update with new message type * Switch to master branch of ros2_control * Remove old controller from pluginlib xml * Use released ros2_controllers
* Remove controller and use upstream one * Fix error messages * Fix last demo section * Use fork for ros2_controllers * Fix CMakeLists and deps * Use upstream ros2_controllers * Update docs with latest changes of controller * Update with new message type * Switch to master branch of ros2_control * Remove old controller from pluginlib xml * Use released ros2_controllers Co-authored-by: Christoph Fröhlich <[email protected]>
This changes the example_10 to use the gpio_command_controller proposed with ros-controls/ros2_controllers#1251
I also mentioned the /dynamic_joint_states topic from JSB.