Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make subprocess output a string instead of bytes, needed in python 3.7 #113

Merged
merged 2 commits into from
Oct 25, 2023
Merged

make subprocess output a string instead of bytes, needed in python 3.7 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2391776
make subprocess output a string instead of bytes, needed in python 3.7
lucasw Mar 22, 2022
9ad6eb7
use hpp instead of deprecated .h pluginlib headers
lucasw Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openni2_camera/ros/openni2_camera_nodelet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ class OpenNI2DriverNodelet : public nodelet::Nodelet

}

#include <pluginlib/class_list_macros.h>
#include <pluginlib/class_list_macros.hpp>
PLUGINLIB_EXPORT_CLASS(openni2_camera::OpenNI2DriverNodelet, nodelet::Nodelet)
2 changes: 1 addition & 1 deletion openni2_launch/src/openni2_launch/wtf_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _device_notfound_subproc(id_manufacturer, id_product):
can be wiped out. See https://github.com/ros-drivers/openni2_camera/pull/80#discussion_r193295442
"""
device_re = re.compile("Bus\s+(?P<bus>\d+)\s+Device\s+(?P<device>\d+).+ID\s(?P<id>\w+:\w+)\s(?P<tag>.+)$", re.I)
df = subprocess.check_output("lsusb")
df = subprocess.check_output("lsusb", text=True)
devices = []
for i in df.split('\n'):
if i:
Expand Down