ROS Interface Node #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address issue #4. This is a working PR and should not be accepted yet. I wanted to elicit feedback.
This PR is largely based on the previous work of @gavanderhoorn. It adds a new file that defines a ros node that listens to the keyence and publishes PCL point clouds.
There are a few key points I'd like to discuss:
The sample rate must be set at the start. There is no adaptation besides stopping the sensor from polling. Perhaps the sample rate should be part of the change program request or it could be a parameter set at start up. PR #10 might also help because it will naturally adapt to whatever the sensor is reading at.