Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update joint_names_irb5400.yaml #198

Open
wants to merge 2 commits into
base: kinetic-devel
Choose a base branch
from

Conversation

aaryanmurgunde
Copy link

The URDF Provided has the these names set, and the name of the controller should match it, if not it gives an error saying "Joint_1 received but not found in the model".

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jul 31, 2023

Thanks for the PR.

I'd rather do things the other way around: the xacro:macro should be updated to use the correct joint names.

Could you update your PR to:

  • revert your changes to the .yaml, and
  • update the xacro:macro to use joint_N names everywhere?

thanks

Copy link
Author

@aaryanmurgunde aaryanmurgunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavanderhoorn Sure! here are the changes that you requested.

Any perticular reason why you want joint_N or just to maintain a standard ?

@gavanderhoorn
Copy link
Member

Any perticular reason why you want joint_N or just to maintain a standard ?

joint_N is the standard naming scheme for joints. Compare irb6600_225_255_macro.xacro, irb4400l_30_243_macro.xacro and irb2400_12_155_macro.xacro.

@aaryanmurgunde
Copy link
Author

aaryanmurgunde commented Aug 3, 2023

joint_N is the standard naming scheme for joints. Compare irb6600_225_255_macro.xacro, irb4400l_30_243_macro.xacro and irb2400_12_155_macro.xacro.

@gavanderhoorn Already updated here in the last commit.

@aaryanmurgunde
Copy link
Author

Hi, @gavanderhoorn do you have an update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants